Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startsWith is not supported on IE11 #8830

Merged
merged 1 commit into from May 8, 2020
Merged

startsWith is not supported on IE11 #8830

merged 1 commit into from May 8, 2020

Conversation

OmarShehata
Copy link
Contributor

The PR #8758 added a startsWith call, which is not supported on IE11.

This PR replaces it with an indexOf() check. Tested with a built Cesium Viewer.

@mramato

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Member

mramato commented May 8, 2020

Confirmed everything now works in IE11 as expected.

@mramato mramato merged commit c2b94b4 into master May 8, 2020
@mramato mramato deleted the fix-ie11 branch May 8, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants