Cesium ion logo - support for data URL scheme

[reginapramesti]

Description of the Problem

In our TerriaJS application, the Cesium ion logo is represented as a data URL because our webpack configuration replaces buildModuleUrl with corresponding require statements - as a result the logo doesn't render. This issue is a result of #8758 which introduces a scheme check on the logo URL. Because TerriaJS doesn't use a http(s) URL scheme, and instead uses the data: scheme for the logo URL, the newly introduced code strips the data: scheme from the URL, and prevents the logo from rendering.

How this PR fixes the Problem

We include the data: scheme check within the if condition in CreditDisplay.js which causes the logo to render appropriately on the TerriaJS application.

Example

This is the data URL used by the TerriaJS application to represent the logo, however when this URL is passed through getDefaultCredit(), the data: is stripped and the logo is stored without a URL scheme. As a result, when loading the logo on the TerriaJS application, the img src looks for a resource on the server, rather than the base64 encoded data.

[cesium-concierge]

Thank you so much for the pull request @reginapramesti! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

• ❌ Missing CONTRIBUTORS.md entry.
  • Please add yourself to the contributors file!
• ❌ Missing CLA.
  • Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[reginapramesti]

I work for CSIRO's Data61, and I believe I am already covered by their CLA

[kring]

Thanks @reginapramesti! The change makes sense to me. @OmarShehata can you easily confirm that this doesn't reintroduce the WebView logo problem fixed in #8758?

[OmarShehata]

It does seem like a safe change. I'd need to get my cordova re-setup, which I'm happy to do and re-test this in the next few days.

[OmarShehata]

Confirmed Cesium ion logo still works when running with this branch on Android with Cordova and there are no unexpected side effects. Thanks @reginapramesti !