-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broken debug depth options in Scene.js #9965
Conversation
Thanks for the pull request @ebogo1!
Reviewers, don't forget to make sure that:
|
* | ||
* @default false | ||
*/ | ||
this.debugShowGlobeDepth = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this property is part of the public API removing it counts as a breaking change and should be mentioned in CHANGES.md
. I don't think we need a deprecation period since it is for debugging only and has been broken for a while now.
/** | ||
* Gets or sets the show globe depth state. This property is observable. | ||
* @type {Boolean} | ||
* @default false | ||
*/ | ||
this.globeDepth = false; | ||
|
||
/** | ||
* Gets or sets the show pick depth state. This property is observable. | ||
* @type {Boolean} | ||
* @default false | ||
*/ | ||
this.pickDepth = false; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about mentioning both of these in the breaking changes section.
@lilleyse I made the changes above. Should the CHANGES.md entry have any more info? The original issue says the debug depths may have been broken since 1.45, but usually any extra info in the Breaking section is for alternative APIs to use after deprecation. |
That should be fine. Thanks @ebogo1. |
This PR removes some code that's been broken for a while: #6763. If we ever fix this code these commits can be reverted, but for now it's helpful to simplify Scene.js, GlobeDepth.js, and PickDepth.js so the Framebuffer code can be refactored.
debugGlobeDepthViewportCommand
inGlobeDepth
debugPickDepthViewportCommand
inPickDepth
debugShowGlobeDepth
anddebugShowPickDepth
(which was only set through the inspector) options fromScene
debugGlobeDepths
array inView
CesiumInspector
widget and view modelSceneSpec