New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate accessor min/max values #620

Merged

lilleyse merged 1 commit into CesiumGS:convert-legacy-extensions-to-pbr from javagl:convert-legacy-extensions-to-pbr-minmax

Aug 4, 2022

Contributor

javagl commented Aug 4, 2022

Details discussed in #619


          Validate accessor min/max values

b4cccd7

javagl mentioned this pull request

Convert glTF 1.0 techniques to PBR materials by default #619

Merged

Contributor

lilleyse commented Aug 4, 2022 •

edited

Loading

One side effect of putting this in updateVersion is it will slow down glTF 1.0 to 2.0 conversion in CesiumJS.

But that's probably not a big concern now that glTF 1.0 assets are relatively rare.

EDIT: I see you already mentioned this in #619

I can imagine that calling this function might be costly for larger models (and maybe it should be possible to enable/disable this step with a command line parameter or so...), and I'm not 100% sure whether that's the right place of calling it and so. But maybe it's worth considering this, just for the validity sake...

lilleyse merged commit 3f41a76 into CesiumGS:convert-legacy-extensions-to-pbr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet