Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add a face that contains only two vertices #120

Merged
merged 1 commit into from Dec 20, 2017
Merged

Don't add a face that contains only two vertices #120

merged 1 commit into from Dec 20, 2017

Conversation

lilleyse
Copy link
Contributor

Fixes #119

@lilleyse lilleyse mentioned this pull request Dec 12, 2017
Closed
@emackey
Copy link
Contributor

emackey commented Dec 12, 2017

Are primitives like POINTS and LINES supported by this converter? Just asking in case this fix might impact them. Not even sure if OBJ does them at all.

@lilleyse
Copy link
Contributor Author

The converter doesn't support points or lines.

The obj format supports them

p v1 v2 v3
l v1 v2 v3

But in this case it was actually an f line that only had two vertices, which seems like a problem with the obj.

@emackey
Copy link
Contributor

emackey commented Dec 12, 2017

Sounds good, thanks!

@likangning93 likangning93 merged commit 09271d2 into master Dec 20, 2017
@likangning93 likangning93 deleted the loading-fix branch December 20, 2017 21:51
lilleyse added a commit that referenced this pull request Nov 1, 2018
@lilleyse
Add specs and CHANGES updates for porting over #120 #133 #136
99806cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilleyse @emackey @likangning93