Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for material that doesn't have a name #173

Merged
merged 2 commits into from Mar 4, 2019
Merged

Fix for material that doesn't have a name #173

merged 2 commits into from Mar 4, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 4, 2019

Fixes #172

There were some issues if a material has an empty name.

@lilleyse lilleyse mentioned this pull request Jan 4, 2019
Closed
@lilleyse lilleyse mentioned this pull request Jan 7, 2019
Closed
@likangning93 likangning93 self-requested a review March 4, 2019 21:29
likangning93
likangning93 reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@likangning93 likangning93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilleyse just the one comment, otherwise this looks good.

lib/loadObj.js Show resolved Hide resolved
@likangning93 likangning93 merged commit ebd7d73 into master Mar 4, 2019
@likangning93 likangning93 deleted the newmtl-without-name branch March 4, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likangning93 likangning93 likangning93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilleyse @likangning93