Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mtl and texture absolute paths #219

Merged
merged 3 commits into from Oct 29, 2019
Merged

Handle mtl and texture absolute paths #219

merged 3 commits into from Oct 29, 2019

Conversation

lilleyse
Copy link
Contributor

Fixes #213

I confirmed that the tests fail if path.resolve is changed back to path.join.

@OmarShehata
Copy link

This works well. My only comment here is I think we should consider setting --secure to be true by default. In general, we should always create tools that are secure by default.

I don't think that should be a big issue for users of this library, since I imagine OBJs with relative absolute paths aren't common, and getting the old behavior would just be a matter of setting --secure false.

@lilleyse lilleyse mentioned this pull request Oct 29, 2019
@lilleyse
Copy link
Contributor Author

I opened a separate issue for secure by default: #220

Is this one ok to merge?

@OmarShehata
Copy link

OmarShehata commented Oct 29, 2019

Yup, this is good! Thanks for opening the issue.

@OmarShehata OmarShehata merged commit 4df7c2a into master Oct 29, 2019
@OmarShehata OmarShehata deleted the absolute-paths branch October 29, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix absolute path textures
2 participants