New optional parameter doubleSidedMaterial to force materials to be rendered on both sides
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chetan-set this looks like a good change - could you sign the Cesium CLA so we can review/merge? https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla |
|
Thank you @lilleyse. I have now signed the Cesium CLA. |
|
Thanks @chetan-set, I had some additional changes that I wanted to push to your branch but in the process managed to auto-close the PR. Anyways, I opened #295 which includes both our commits. |
|
Thank you @lilleyse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started a disussion here to discuss the merits of setting the doubleSided parameter of gltf materials to true in some cases. This pull request implements that change