Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambient of 1,1,1 #70

Merged
merged 1 commit into from Apr 23, 2017
Merged

Fix ambient of 1,1,1 #70

merged 1 commit into from Apr 23, 2017

Conversation

lilleyse
Copy link
Contributor

Fixes #69
This is also already handled on the gltf-2.0 branch.

@mramato
Copy link
Contributor

mramato commented Apr 23, 2017

Awesome! Thanks @lilleyse.

@pjcozzi this fixes the wash out issues we were seeing with photogrammetry models. Can you please merge if you're happy (I don't have commit access) thanks.

@lasalvavida
Copy link
Contributor

I can get it, looks good to me too

@lasalvavida lasalvavida merged commit 2327a88 into master Apr 23, 2017
@mramato
Copy link
Contributor

mramato commented Apr 23, 2017

Thanks @lasalvavida.

@lilleyse lilleyse deleted the fix-ambient branch April 23, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilleyse @mramato @lasalvavida