Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pull, patch and install bundled apks #86

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

alright21
Copy link
Contributor

This pull request solves #85
Before completing the last step (patching), I have some doubts on the code structure, and I would like to have some input:

  • for pulling all the apks, I added the -a flag to pull all the apks
  • for installing multiple apks in a single bundle, I created a new command called installmultiple, where you have to insert all the apk, and the code will execute adb install-multiple
  • I am not sure for patching if it is better to use a flag (e.g. -a) or create a new command. What do you think about it?
    Moreover, I modified the argument parsing, from splitting the line to parsing the arg_list, using the Statement paramenters accordingly. Is this approach fine?
  • is it fine to raise the FileNotFoundException and handle them in the except clause?
  • Finally, do you think that we should consider adding argparse for better argument parsing or not? Probably it is not necessary for the majority of the commands, but in some cases it could be useful

@Ch0pin
Copy link
Owner

Ch0pin commented Mar 20, 2024

that was fast :) , thank you very much @alright21 , give me some time to check this out.

@Ch0pin
Copy link
Owner

Ch0pin commented Mar 21, 2024

@alright21

I am not sure for patching if it is better to use a flag (e.g. -a) or create a new command. What do you think about it?

I think it is better to create a new one

Moreover, I modified the argument parsing, from splitting the line to parsing the arg_list, using the Statement paramenters accordingly. Is this approach fine?

It is absolutely fine, as I said already, I need to go through the code and fix few things and probably follow the same approach for other commands to.

is it fine to raise the FileNotFoundException and handle them in the except clause?

Yes it is absolutely fine

Finally, do you think that we should consider adding argparse for better argument parsing or not? Probably it is not necessary for the majority of the commands, but in some cases it could be useful

I am fine with that too.

@alright21
Copy link
Contributor Author

Ok thanks for your reply, I will work on that

@Ch0pin Ch0pin marked this pull request as ready for review April 4, 2024 13:49
@Ch0pin Ch0pin merged commit 6375453 into Ch0pin:master Apr 4, 2024
1 check passed
@alright21
Copy link
Contributor Author

Hi @Ch0pin, I am sorry but I am still working on the patch part, so this pull request does not do that yet. Was it fine to merge it? sorry I was quite busy these days

@Ch0pin
Copy link
Owner

Ch0pin commented Apr 4, 2024

Hi @alright21, yes this one seems fine. No worries, take your time with the merge option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants