Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_port and delete_port in canvas are not included in __all__ #192

Closed
bgeisberger opened this issue Apr 12, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@bgeisberger
Copy link
Contributor

  • Nipyapi version: 0.14.2

Description

Inspection tools complain about using protected members when using create_port or delete_port from canvas. Those methods look for me like they are intended to be public, but they are not included in all.

What I Did

I tried to use create_port and delete_port.

Urgency

Not urgent

@Chaffelson Chaffelson self-assigned this Jun 21, 2020
@Chaffelson Chaffelson added this to the 0.15.0 milestone Jun 21, 2020
@Chaffelson Chaffelson added the bug label Jun 21, 2020
Chaffelson added a commit that referenced this issue Nov 5, 2020
…to Next branch

Added create and delete port to _all_ in canvas.py. Fixes #192
Coding style fixes.
@Chaffelson
Copy link
Owner

Fixed in 0.15.0 release

Chaffelson added a commit that referenced this issue Nov 6, 2020
* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Add greedy control to several get_ functions to support exact matching on operation
Add basicAuth support to nifi client and security module
Updated test containers to 1.11.4
Added special case for 'root' to get_processor
Corrected list_invalid_processors to correctly report an empty list
update_controller now has a refresh option
get_template now correctly returns None if Template not found
is_endpoint_up now has a reasonable default timeout
automatically trim API endpoint URLs of trailing slash to avoid really really annoying errors

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Adding vscode to gitignore because OSX is bloody stupid and invasive

* Bump version: 0.14.1 → 0.14.2

* Bump version: 0.14.2 → 0.14.3

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Updated contributing.rst to include guidance on new features going into Next branch
Added create and delete port to _all_ in canvas.py. Fixes #192
Coding style fixes.

* Bump version: 0.14.3 → 0.15.0

* Doc fixes for release
Update history for release
rsaggino added a commit to rsaggino/nipyapi that referenced this issue Mar 29, 2021
* Patch for authentication issue (Chaffelson#193)

bumpversion to 0.14.3
Patch authentication issue to provide control for which authentication method is used in the config. Default is set to tokenAuth per previous behavior.

* Fix create empty group (Chaffelson#207)

* Fixed: Can create a group without pass users list

* Fixed: Can create a group without pass users list #1

* Allow deploy_template to use floats for positions (Chaffelson#191)

* Fix searching by unique identifier (Chaffelson#205)

* Fix the search according unique identifier

* Fix the search according unique identifier and update functions doc

* Minor typo correction

Co-authored-by: Dan Chaffelson <chaffelson@gmail.com>

* Added Parameter Contexts API to docs (Chaffelson#196)

* Added Parameter Contexts API to docs

* omit docs from coverage stats.

* keep track of the docker container object, and use it to kill the container when we are done (Chaffelson#203)

set auto remove to true

* fixed funnel position (Chaffelson#224)

* fixed funnel position, added test and contribution markdown

* removed duplicate file

* add functions for working reading template.xml files into TemplateEnt… (Chaffelson#223)

* add functions for working reading template.xml files into TemplateEntity instances

* undo formatting

* fix import

* fix test assertion and type

* Merge 0.15.0 release from Next to Master (Chaffelson#228)

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Add greedy control to several get_ functions to support exact matching on operation
Add basicAuth support to nifi client and security module
Updated test containers to 1.11.4
Added special case for 'root' to get_processor
Corrected list_invalid_processors to correctly report an empty list
update_controller now has a refresh option
get_template now correctly returns None if Template not found
is_endpoint_up now has a reasonable default timeout
automatically trim API endpoint URLs of trailing slash to avoid really really annoying errors

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Adding vscode to gitignore because OSX is bloody stupid and invasive

* Bump version: 0.14.1 → 0.14.2

* Bump version: 0.14.2 → 0.14.3

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Updated contributing.rst to include guidance on new features going into Next branch
Added create and delete port to _all_ in canvas.py. Fixes Chaffelson#192
Coding style fixes.

* Bump version: 0.14.3 → 0.15.0

* Doc fixes for release
Update history for release

* Update ruamel.yaml from 0.16.10 to 0.16.12 (Chaffelson#219)

* check-version should ignore snapshot (Chaffelson#232)

* add public api for deserializing models (Chaffelson#236)

* update dump so that it supports dumping swagger entities
this pr also fixes a bug where the nifi style of xml was resulting
in incomplete objects

* update to sync with next branch

Co-authored-by: Dan Chaffelson <chaffelson@gmail.com>
Co-authored-by: Raz <razdob@gmail.com>
Co-authored-by: Bernhard Geisberger <41961259+bgeisberger@users.noreply.github.com>
Co-authored-by: Eric Secules <esecules@gmail.com>
Co-authored-by: Otto Fowler <ottobackwards@gmail.com>
Co-authored-by: Clément Vial <clement.vial@gmail.com>
Co-authored-by: pyup.io bot <github-bot@pyup.io>
rsaggino pushed a commit to rsaggino/nipyapi that referenced this issue Mar 29, 2021
* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Add greedy control to several get_ functions to support exact matching on operation
Add basicAuth support to nifi client and security module
Updated test containers to 1.11.4
Added special case for 'root' to get_processor
Corrected list_invalid_processors to correctly report an empty list
update_controller now has a refresh option
get_template now correctly returns None if Template not found
is_endpoint_up now has a reasonable default timeout
automatically trim API endpoint URLs of trailing slash to avoid really really annoying errors

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Adding vscode to gitignore because OSX is bloody stupid and invasive

* Bump version: 0.14.1 → 0.14.2

* Bump version: 0.14.2 → 0.14.3

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Add greedy control to get_processor to support exact matching on get operation
Add basicAuth support to nifi client and security module

* Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth
Improved Linting and Logging statements in security.py

* Update base clients to NiFi-1.12.1 and Registry-0.7.0

* Updated contributing.rst to include guidance on new features going into Next branch
Added create and delete port to _all_ in canvas.py. Fixes Chaffelson#192
Coding style fixes.

* Bump version: 0.14.3 → 0.15.0

* Doc fixes for release
Update history for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants