Allow deploy_template to use floats for positions #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay here - I am on isolation childcare, I should have more time for review and merging from next month |
|
Rebased onto Current master and all tests passed, thanks for your contribution! |
rsaggino
added a commit
to rsaggino/nipyapi
that referenced
this pull request
Mar 29, 2021
* Patch for authentication issue (Chaffelson#193) bumpversion to 0.14.3 Patch authentication issue to provide control for which authentication method is used in the config. Default is set to tokenAuth per previous behavior. * Fix create empty group (Chaffelson#207) * Fixed: Can create a group without pass users list * Fixed: Can create a group without pass users list #1 * Allow deploy_template to use floats for positions (Chaffelson#191) * Fix searching by unique identifier (Chaffelson#205) * Fix the search according unique identifier * Fix the search according unique identifier and update functions doc * Minor typo correction Co-authored-by: Dan Chaffelson <chaffelson@gmail.com> * Added Parameter Contexts API to docs (Chaffelson#196) * Added Parameter Contexts API to docs * omit docs from coverage stats. * keep track of the docker container object, and use it to kill the container when we are done (Chaffelson#203) set auto remove to true * fixed funnel position (Chaffelson#224) * fixed funnel position, added test and contribution markdown * removed duplicate file * add functions for working reading template.xml files into TemplateEnt… (Chaffelson#223) * add functions for working reading template.xml files into TemplateEntity instances * undo formatting * fix import * fix test assertion and type * Merge 0.15.0 release from Next to Master (Chaffelson#228) * Add greedy control to get_processor to support exact matching on get operation Add basicAuth support to nifi client and security module * Add greedy control to several get_ functions to support exact matching on operation Add basicAuth support to nifi client and security module Updated test containers to 1.11.4 Added special case for 'root' to get_processor Corrected list_invalid_processors to correctly report an empty list update_controller now has a refresh option get_template now correctly returns None if Template not found is_endpoint_up now has a reasonable default timeout automatically trim API endpoint URLs of trailing slash to avoid really really annoying errors * Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth Improved Linting and Logging statements in security.py * Adding vscode to gitignore because OSX is bloody stupid and invasive * Bump version: 0.14.1 → 0.14.2 * Bump version: 0.14.2 → 0.14.3 * Add greedy control to get_processor to support exact matching on get operation Add basicAuth support to nifi client and security module * Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth Improved Linting and Logging statements in security.py * Update base clients to NiFi-1.12.1 and Registry-0.7.0 * Add greedy control to get_processor to support exact matching on get operation Add basicAuth support to nifi client and security module * Added configuration control for NiFi Authentication mode, either tokenAuth or basicAuth Improved Linting and Logging statements in security.py * Update base clients to NiFi-1.12.1 and Registry-0.7.0 * Updated contributing.rst to include guidance on new features going into Next branch Added create and delete port to _all_ in canvas.py. Fixes Chaffelson#192 Coding style fixes. * Bump version: 0.14.3 → 0.15.0 * Doc fixes for release Update history for release * Update ruamel.yaml from 0.16.10 to 0.16.12 (Chaffelson#219) * check-version should ignore snapshot (Chaffelson#232) * add public api for deserializing models (Chaffelson#236) * update dump so that it supports dumping swagger entities this pr also fixes a bug where the nifi style of xml was resulting in incomplete objects * update to sync with next branch Co-authored-by: Dan Chaffelson <chaffelson@gmail.com> Co-authored-by: Raz <razdob@gmail.com> Co-authored-by: Bernhard Geisberger <41961259+bgeisberger@users.noreply.github.com> Co-authored-by: Eric Secules <esecules@gmail.com> Co-authored-by: Otto Fowler <ottobackwards@gmail.com> Co-authored-by: Clément Vial <clement.vial@gmail.com> Co-authored-by: pyup.io bot <github-bot@pyup.io>
rsaggino
pushed a commit
to rsaggino/nipyapi
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NiFi API allows to use floats for positions. Type checkers are complaining about
deploy_templateif floats are used for locations. It still works, but the function should represent what the API is actually capable of.