Weak subjectivity #579
Weak subjectivity #579
Conversation
BeroBurny
requested review from
morrigan and
mpetrunic
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #579 +/- ##
========================================
Coverage 48.17% 48.17%
========================================
Files 117 117
Lines 2115 2115
Branches 231 231
========================================
Hits 1019 1019
Misses 1067 1067
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
# Conflicts: # src/renderer/ducks/beacon/sagas.ts
Codecov Report
@@ Coverage Diff @@
## develop #579 +/- ##
==========================================
Coverage ? 48.02%
==========================================
Files ? 117
Lines ? 2124
Branches ? 231
==========================================
Hits ? 1020
Misses ? 1075
Partials ? 29
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -30,7 +30,9 @@ jobs: | |||
| run: yarn run test:unit && yarn run test:components | |||
|
|
|||
| - name: Run e2e tests | |||
| run: yarn run test:e2e | |||
| run: | | |||
| yarn add cheerio-select | |||
There was a problem hiding this comment.
--frozen-lockfile dose not install cheerio-select even if is cheerio-select part of package.json
There was a problem hiding this comment.
if it's in lockfile it must be installed
There was a problem hiding this comment.
I have no idea why, maybe you can figure it out?
Short description of work done
PR Checklist
Changes
Issues
Closes #576