Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dockerfile): add Dockerfile with relating github action #41

Merged
merged 17 commits into from
Apr 27, 2021

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Apr 19, 2021

Desc

This PR provides the Dockerfile for PINT following the Dockfile of paritytech/polkadot.

For the auto-test of the integration of the parachain and relaychain in CI, as there is a tool polkadot-launch and paritytech/polkadot-launch#83 is WIP, I think we can open a new issue to discuss.

Tests

  • Branch cl/docker-staging which use the same code of this PR
  • Run docker run -it chainsafe/pint --version to check if the image works

Refs


Closes #6

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2021

CLA assistant check
All committers have signed the CLA.

@clearloop clearloop marked this pull request as draft April 19, 2021 07:44
@clearloop
Copy link
Contributor Author

clearloop commented Apr 20, 2021

rustc version problem

version error
nightly Could not compile polkadot-service
nightly-2020-11-24 Could not compile kusama-runtime

According to https://github.com/PureStake/moonbeam/blob/master/docker/polkadot-relay.Dockerfile, trying paritytech/ci-linux:production now

@clearloop clearloop marked this pull request as ready for review April 23, 2021 15:29
@clearloop clearloop marked this pull request as draft April 23, 2021 15:41
@clearloop
Copy link
Contributor Author

clearloop commented Apr 24, 2021

There is a cache problem in CI, maybe could be fixed by #45

@clearloop clearloop marked this pull request as ready for review April 26, 2021 06:42
@clearloop clearloop added the needs review PR needs reviewing label Apr 26, 2021
@clearloop
Copy link
Contributor Author

Needs review and advice @mattsse @willemolding

@mattsse
Copy link
Contributor

mattsse commented Apr 26, 2021

I'll take this on, however I need a clean install of my docker setup first, something is definitely broken on my end.

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
pulling and running the image from dockerhub works great!
In order to test building locally I think it would require a rebase from main first, because I got this error error: no matching package named cumulus-pallet-xcm-handler
Nevermind, this was due to a modified lock file.

@mattsse mattsse added approved PR approved to merge and removed needs review PR needs reviewing labels Apr 27, 2021
@clearloop clearloop merged commit c80022f into main Apr 27, 2021
@clearloop clearloop deleted the cl/docker branch April 27, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approved to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Construct Dockerfile
3 participants