-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xcm transacting support #97
Conversation
Is there any reference for XCM calls? The structure here seems like a pallet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename remote-asset-manager/src/calls.rs
to remote-asset-manager/src/calls/mod.rs
?
Or move the calls
to /root/primitives/xcm-calls
?
Here are the expanded versions of the staking pallet and the polkadot runtime |
I like the idea of moving this to primitives! |
Emmmm, this |
The relevant decoding happens upon arrival XCM Transact here: https://github.com/paritytech/polkadot/blob/master/xcm/xcm-executor/src/lib.rs#L172-L177 |
primitives/xcm-calls/README.md
Outdated
@@ -0,0 +1 @@ | |||
License: LGPL-3.0-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add links like
- https://github.com/paritytech/polkadot/blob/master/runtime/polkadot/src/lib.rs
- https://github.com/paritytech/polkadot/blob/master/xcm/xcm-executor/src/lib.rs#L172-L177
To this README so that we can trace the new updates easily from the upstream when we need to update this pallet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, will add links and will also reference them in the docs
Changes
pallet_proxy
andpallet_staking
calls on different chainsEncodeWith
trait was introduced which is intended as wrapper aroundcode::Encode
but with an additional context provided (AssetId or Location) to encode the type properlystaking
,proxy
) require their ownEncoder
type inside the remote asset manager, they ensure that the calls are encoded correctly and will be configured in the runtime.Builds on #79
Tests
Issues