Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Dappeteer 4.0.1 broken dependency #228

Closed
Lykhoyda opened this issue Dec 15, 2022 · 0 comments · Fixed by #230
Closed

Dappeteer 4.0.1 broken dependency #228

Lykhoyda opened this issue Dec 15, 2022 · 0 comments · Fixed by #230
Assignees
Labels
bug Something isn't working

Comments

@Lykhoyda
Copy link
Contributor

Describe the bug
When we use dappeteer as npm package, import from test folder to src will break because dev dependency is not installed (expected). Therefore importing "export const EXAMPLE_WEBSITE = "http://example.org";" to the src folder from test/ will fail due to uninstalled web3 dependency. As a file will be resolved entirely and not just the export part.

To Reproduce
install dappeteer v4.0.1 and call method "initSnapEnv()"

Logs

Cannot find module 'web3' from '../../node_modules/@chainsafe/dappeteer/dist/test/constant.js'

Expected behavior
We shouldn't use a test folder when dappeteer is used as a package

System:

  • OS: Ventura 13.01
  • NodeJs version 16
  • dAppeteer version 4.0.1
  • testing framework jest
  • testing framework version 26
@Lykhoyda Lykhoyda added the bug Something isn't working label Dec 15, 2022
@Lykhoyda Lykhoyda self-assigned this Dec 15, 2022
Lykhoyda added a commit that referenced this issue Dec 15, 2022
@Lykhoyda Lykhoyda mentioned this issue Dec 15, 2022
4 tasks
mpetrunic pushed a commit that referenced this issue Dec 15, 2022
mpetrunic pushed a commit that referenced this issue Dec 15, 2022
mpetrunic added a commit that referenced this issue Dec 15, 2022
fix #228

Co-authored-by: Anton Lykhoyda <lykhoyda@gmail.com>
venuswhispers added a commit to venuswhispers/My_dAppeteer that referenced this issue Feb 19, 2024
fix ChainSafe/dappeteer#228

Co-authored-by: Anton Lykhoyda <lykhoyda@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done/Closed
Development

Successfully merging a pull request may close this issue.

1 participant