Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix: dappeteer dependency #229

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix: dappeteer dependency #229

merged 1 commit into from
Dec 15, 2022

Conversation

Lykhoyda
Copy link
Contributor

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

#228

Closes #

@Lykhoyda Lykhoyda changed the base branch from master to unstable December 15, 2022 15:55
BeroBurny
BeroBurny previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeroBurny BeroBurny changed the base branch from unstable to master December 15, 2022 16:05
@BeroBurny BeroBurny dismissed their stale review December 15, 2022 16:05

The base branch was changed.

@BeroBurny BeroBurny changed the base branch from master to unstable December 15, 2022 16:05
@mpetrunic mpetrunic merged commit b76ca7c into unstable Dec 15, 2022
@mpetrunic mpetrunic deleted the lykhoyda/fix_dappeteer_dependency branch December 15, 2022 16:35
@mpetrunic
Copy link
Member

@Lykhoyda @BeroBurny why not directly to master?

mpetrunic pushed a commit that referenced this pull request Dec 15, 2022
@Lykhoyda @mpetrunic
fix: dappeteer dependency (#229)
e47b2d1 
fix #228
mpetrunic added a commit that referenced this pull request Dec 15, 2022
@mpetrunic @Lykhoyda
fix: dappeteer dependency (#229) (#230)
2b6c213 
fix #228

Co-authored-by: Anton Lykhoyda <lykhoyda@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Merged
This was referenced May 2, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@BeroBurny BeroBurny BeroBurny left review comments

@irubido irubido Awaiting requested review from irubido

Assignees
No one assigned
Labels
None yet
Projects
Dappeteer
Status: Done/Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lykhoyda @mpetrunic @BeroBurny