Add multiaddr to ENR

[D4nte]

No description provided.

[D4nte]

This was meant for my own fork

[dapplion]

Feel free to do a PR upstream if you feel a feature is missing!

[D4nte]

hi There,

Few comments and I am not sure at this stage what is the most straightforward way.

• I defined a new keys: multiaddrs for ENR to contact information that cannot be encoded with existing ENR pre-defined keys such as fqdn, websocket port, onion address, quic, etc. The spec is here: 31/WAKU2-ENR: Waku v2 usage of ENR vacp2p/rfc#465 and PR there: Add multiaddrs key for websocket dns peer info D4nte/discv5#1
• My first usage of ENR is with EIP-1459. I have a draft PR that implements it: Implement EIP-1459 for node discovery waku-org/js-waku#305 but it needs re-work:
  • to use the new ENR code
  • to make it implement the libp2p discovery module interface

For simplicity sake, I decided to import the code in js-waku: waku-org/js-waku#324

To not depend on several crypto library, I also swapped bcrypto for secp256k1.
Note that my target is mainly browser.

Now, I intend at some point to extract the ENR code and the EIP-1459 code as their own package so other projects can use it.

I will also need to implement discv5 as well, but it needs to use the ENR with multiaddrs so I won't be able to use the present library out of the box.

Having said that, I am keen to collaborate if you think the core change I implemented (multiaddrs key on ENR) is something you need. Let me know what you think.

[dapplion]

@wemeetagain I'm sure we can extend enr + discv5 to support this changes!

[wemeetagain]

Hey @D4nte
I think the multiaddrs key is great, happy to push upstream.

Also we'd love to split out the ENR logic into a separate package.

[D4nte]

Thank you both for your comments.

What are your thoughts in regards of the cryptography backend? Bcrypto vs secpk1? Was bcrypto chosen because it supports various curves, even though only secpk1 is used for ENRs?

I believe both our project target browser environment so limiting dependencies is always preferred.

Ps: I am in leave at the moment so apologies if I take time to reply/action.

[wemeetagain]

What are your thoughts in regards of the cryptography backend? Bcrypto vs secpk1? Was bcrypto chosen because it supports various curves, even though only secpk1 is used for ENRs?

I think bcrypto was used because it was already being used for discv5 crypto.
My hope was ideally we could use libp2p-crypto.