Add multiaddrs key for websocket dns peer info
#1
+113
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4nte
changed the title
multiaddr key for websocket dns peer info
|
I explored the possibility of encoding several multiaddresses in the This resulted in RLP encoded size of Removing the peer id from the encoded multiaddr does allow the encoding of 2, even 3 (not 4) multiaddresses while remaining under 300 bytes post RLP encoding. |
D4nte
changed the title
multiaddr key for websocket dns peer infomultiaddrs key for websocket dns peer info
This can be used to store peer information that cannot be encoded with the pre-defined ENR keys such as websocket details, fqdn, etc. Multiaddresses present in the `multiaddrs` field must not contain a peer id. The `secp256k1` field should be used for the peer id by storing the public key.
D4nte
added a commit
to waku-org/js-waku
that referenced
this pull request
Oct 26, 2021
Imported from D4nte/discv5#1 Replaced bcrypto backend with secp256k1.
D4nte
added a commit
to waku-org/js-waku
that referenced
this pull request
Oct 26, 2021
Imported from D4nte/discv5#1 Replaced bcrypto backend with secp256k1.
D4nte
added a commit
to waku-org/js-waku
that referenced
this pull request
Oct 26, 2021
Imported from D4nte/discv5#1 Replaced bcrypto backend with secp256k1.
D4nte
added a commit
to waku-org/js-waku
that referenced
this pull request
Dec 6, 2021
Imported from D4nte/discv5#1 Replaced bcrypto backend with secp256k1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.