Repatriate arbitrary implementations

[lemmih]

Issue summary

We wrap several types in order to implement the Arbitrary trait for them. Ideally we want the upstream libraries to natively support quickcheck. We should submit PRs that add quickcheck support under an optional feature.

• Cid: Bump quickcheck from 0.9 to 1.0 multiformats/rust-cid#125
• Ipld: https://crates.io/crates/libipld-core
• ActorState: https://crates.io/crates/fvm
• Address, PoStProof, Message, Signature, SignatureType: https://crates.io/crates/fvm_shared

Other information and links

• Ipld PR Implement quickcheck::Arbitrary for IPLD type for testing ipld/libipld#167
• fvm_shared PR Add quickcheck::Arbitrary for some types filecoin-project/ref-fvm#1037
• fvm PR implement Arbitrary trait for ActorState filecoin-project/ref-fvm#1084
  The fvm_shared Pr needs to be merged first before ActorState is implemented. The PR is ready to be opened in the meantime

[lemmih]

@connormullett Remember to add links to the PRs.

[lemmih]

@tyshko5 You want this task?

[tyshko5]

@tyshko5 You want this task?

Sure. Only ActorState left, right?

[lemmih]

We also need to follow-up on the other PRs and make sure they are merged.

[lemmih]

@tyshko5 The ActorState implementations needs to be updated once the Address code has been merged.

[lemmih]

@tyshko5 Could you push this PR to completion: ipld/libipld#157 ? If you're unsure of what to do, ask in our slack channel.

[tyshko5]

@tyshko5 Could you push this PR to completion: ipld/libipld#157 ? If you're unsure of what to do, ask in our slack channel.

Ok

[lemmih]

Status:

• IPLD: PR is done and will be merged soon: Implement quickcheck::Arbitrary for IPLD type for testing ipld/libipld#167
• fvm_shared: PR is done but requires buy-in from owners: Add quickcheck::Arbitrary for some types filecoin-project/ref-fvm#1037
• fvm: A new PR needs to be created after fvm_shared is updated. @tyshko5 will create the new PR.

[lemmih]

The fvm_shared PR got merged. Please update the arbitrary implementation for ActorState, @tyshko5. Reply to my message with an emoji once you've seen this, know what you need to do, and have no blockers.

[tyshko5]

filecoin-project/ref-fvm#1162

[lemmih]

Blocked. More details: filecoin-project/ref-fvm#1211

[lemmih]

This is no longer blocked with the release of FVM3.

@tyshko5 @hanabi1224 @creativcoder @sudo-shashank, feel free to take this if you're running low on tasks.

[lemmih]

(Partially unblocked - the cid crate still cannot be upgraded)

[jdjaustin]

It appears PoStProof was not included in the fvm_shared PR: filecoin-project/ref-fvm#1037.

[tyshko5]

(Partially unblocked - the cid crate still cannot be upgraded)

If cid still cannot be updated, then we still cannot repatriate ActorState

[tyshko5]

filecoin-project/ref-fvm#1037

filecoin-project/ref-fvm#1684

[jdjaustin]

mod arb is private. I believe it needs to be public, unless there is a workaround or I'm not using it correctly. https://github.com/ipld/libipld/blob/d7ac11d8433d3bf54e626382a2091ac63fccd577/core/src/lib.rs#L19

[lemmih]

mod arb is private. I believe it needs to be public, unless there is a workaround or I'm not using it correctly. https://github.com/ipld/libipld/blob/d7ac11d8433d3bf54e626382a2091ac63fccd577/core/src/lib.rs#L19

You should be able to access the implementations just fine.

[lemmih]

Done.