Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert updates to cid/multihash #1211

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Revert updates to cid/multihash #1211

merged 2 commits into from
Dec 7, 2022

Conversation

Stebalien
Copy link
Member

Unfortunately, updating cid & mutlihash breaks pretty much everything:

  • The FFI imports two versions of the FVM which now use two different CID/Multihash versions.
  • We have a common blockstore trait that uses CID in the interface.
  • This will likely cause hell for builtin actors.

We can un-revert this if we can backport the changes. But we're not updating cid and/or multihash for the foreseeable future.

@Stebalien
Copy link
Member Author

If someone wants to make this happen, they'll need to either:

  1. Create patch releases of cid/multihash.
  2. Add an abstraction to the filecoin-ffi to handle translating CIDs and the blockstore.

But I really don't have time for that right now.

@Stebalien
Copy link
Member Author

@lemmih I'm really sorry about this. If you can find another way, I'd love to hear it.

@Stebalien Stebalien merged commit ffb7238 into master Dec 7, 2022
@Stebalien Stebalien deleted the feat/revert-cidmultihash branch December 7, 2022 05:02
@lemmih
Copy link
Contributor

lemmih commented Dec 7, 2022

@lemmih I'm really sorry about this. If you can find another way, I'd love to hear it.

Can't we just bump the CID dependency everywhere?

@lemmih
Copy link
Contributor

lemmih commented Dec 7, 2022

@lemmih I'm really sorry about this. If you can find another way, I'd love to hear it.

filecoin-ffi already deals with difference versions of all the shared types. It having to deal with different versions of cid only seems fitting.

@vmx
Copy link
Contributor

vmx commented Dec 7, 2022

As it's kind of related. There was another breaking rust-multihash release yesterday and there will be a breaking rust-cid release soon.

@Stebalien Stebalien mentioned this pull request Dec 7, 2022
5 tasks
@lemmih
Copy link
Contributor

lemmih commented Dec 7, 2022

@Stebalien Given that fvm doesn't follow semantic versioning, how about we bump to cid-0.9 and release a new version of fvm-2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants