Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActorState impl after fvm_shared update #1162

Merged

Conversation

tyshko5
Copy link
Contributor

@tyshko5 tyshko5 commented Nov 29, 2022

No description provided.

fvm/Cargo.toml Outdated Show resolved Hide resolved
fvm/src/state_tree.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #1162 (aca20a7) into master (dd79a13) will increase coverage by 6.98%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   43.10%   50.08%   +6.98%     
==========================================
  Files         128      128              
  Lines       13110    11300    -1810     
==========================================
+ Hits         5651     5660       +9     
+ Misses       7459     5640    -1819     
Impacted Files Coverage Δ
fvm/src/state_tree.rs 77.69% <ø> (+10.66%) ⬆️
shared/src/math.rs 0.00% <0.00%> (ø)
fvm/src/trace/mod.rs 0.00% <0.00%> (ø)
shared/src/reward.rs 0.00% <0.00%> (ø)
shared/src/message.rs 0.00% <0.00%> (ø)
shared/src/receipt.rs 0.00% <0.00%> (ø)
shared/src/sys/mod.rs 0.00% <0.00%> (ø)
shared/src/sys/out.rs 0.00% <0.00%> (ø)
fvm/src/gas/outputs.rs 0.00% <0.00%> (ø)
fvm/src/kernel/hash.rs 0.00% <0.00%> (ø)
... and 84 more

@tyshko5 tyshko5 marked this pull request as ready for review November 30, 2022 09:33
fvm/src/state_tree.rs Outdated Show resolved Hide resolved
Stebalien
Stebalien previously approved these changes Nov 30, 2022
@Stebalien
Copy link
Member

Ah, wait, still need to use different CIDs.

@Stebalien Stebalien dismissed their stale review November 30, 2022 17:31

not quite ready

@tyshko5
Copy link
Contributor Author

tyshko5 commented Dec 5, 2022

@Stebalien @raulk Since this PR (#1107) is merged, could you, please, release new versions of the crates in this repository, after merging this PR? That would unblock some upgrades, since cid v0.9.0 finally got some arbitrary implementations

@lemmih
Copy link
Contributor

lemmih commented Dec 5, 2022

@Stebalien @raulk Since this PR (#1107) is merged, could you, please, release new versions of the crates in this repository, after merging this PR? That would unblock some upgrades, since cid v0.9.0 finally got some arbitrary implementations

The v3 release is already in the works.

@Stebalien Stebalien merged commit 83050e8 into filecoin-project:master Dec 7, 2022
Stebalien added a commit that referenced this pull request Dec 7, 2022
Stebalien added a commit that referenced this pull request Jun 28, 2023
Stebalien added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants