Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BlockHeader builder pattern #124

Merged
merged 5 commits into from
Jan 6, 2020
Merged

Conversation

austinabell
Copy link
Contributor

  • The BlockHeader is really hard to construct because of all of the fields and dependencies needed to build it. This allows constructing only the necessary parts and defaulting most
  • Was building off these changes but figure these can come in before because there is a chance there could be a conflict with what someone else is working on.

@dutterbutter let me know if you want me to make any more of those fields mandatory if it affects it in future work (can always change later though)

/// weight is the aggregate chain weight of the parent set
#[builder(default)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you consistently add white space

@austinabell austinabell mentioned this pull request Jan 6, 2020
@austinabell austinabell merged commit 957d052 into master Jan 6, 2020
@austinabell austinabell deleted the austin/headerbuilder branch January 10, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants