Implement Basic SyncManager #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ec2,
ansermino,
GregTheGreek and
dutterbutter
austinabell
force-pushed
the
austin/syncman
branch
from
eeb9974
to
2fcec57
Compare
austinabell
force-pushed
the
austin/syncman
branch
from
2fcec57
to
fcf661b
Compare
GregTheGreek
reviewed
Jan 8, 2020
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
no can do sir, this is testing private functionality, needs to be here
GregTheGreek
approved these changes
Jan 8, 2020
seperate folders is only for integration tests, unit tests for private variables and functionality have to be within the module, can be in a seperate test file but I thought this was the convention we agreed on |
dutterbutter
reviewed
Jan 8, 2020
dutterbutter
reviewed
Jan 8, 2020
dutterbutter
approved these changes
Jan 8, 2020
ec2
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch depends on the header builder pattern #124 so I will just change the base branch to master and open for review once that comes in.I only built out the components that were necessary since this stuff is not defined in the spec and didn't want to assume anything.Wanted to open this up as draft on the off change someone wanted to start any of this.