catch panic in verify_window_post
#1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
added
Bug
Maintenance
Status: Needs Review
Crypto
Actor
elmattic
approved these changes
Jan 12, 2022
|
Happy to include this in 0.2.0 if you can fix the tests and linter |
noot
force-pushed
the
ec2/filecoin-proofs-api-0.11
branch
from
e369966
to
a4b409b
Compare
|
don't merge this yet - updating the rand version causes a state root mismatch |
is there no test for this? |
|
@q9f not right now, I have to manually sync the node to see if it's compatible with mainnet still. it would be nice to have an automated test for that |
noot
changed the title
verify_window_post
q9f
added a commit
that referenced
this pull request
Jan 14, 2022
q9f
added a commit
that referenced
this pull request
Jan 18, 2022
* ci: run github actions on os matrix * ci: deduplicate github workflows * ci: add nightly workflow * ci: add binary install step * ci: further deduplicate work * ci: purge circleci * ci: run tools on msrv * ci: use gh pages deploy action * scripts: remove docs script * docs: update readme * github: update codeowners * ci: enable codecov * ci: fix syntax * docs: restore badges * ci: purge codecov config * ci: use tarpaulin to gather coverage * ci: move coverage to dedicated job * ci: enable buildjet runners * ci: reduce matrix for testing * ci: fix syntax * make: parallelize tests * ci: ignore clippy::redundant-clone * ci: add dependencies * ci: attempt multiple runners * ci: remove broken cache step * ci: reenable macos * make: fix test * ci: automatically cancel previous runs * blockchain/msgpool: disable flaky test, ref #1369 * ci: increase tarpaulin timeout * ci: add rust caching action * blockchain/msgpool: disable more flaky tests, ref #1369 * blockchain/msgpool: disable more flaky tests, ref #1369 * make: make sure tests run in release mode * blockchain/msg_pool: reenable tests in release mode * ci: remove msrv = stable * make: ignore clippy::to-string-in-format-args * ci: further reduce test threads * ci: add build matrix for low priority jobs * ci: further optimize threads * chore: clean up * cargo: add dev profile without debug symbols * ci: populate environment * ci: fix profile * ci: nit * ci: enable incremental builds * ci: resolve merge of #1365 * ci: progressively cache all rust jobs * ci: fix gh pages action version string * ci: fix docs job dry-run condition * make: remove resolved clippy exceptions * ci: remove redundancy in docs job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
verify_window_postReference issue to close (if applicable)
Closes
Other information and links