Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run github actions on buildjet #1366

Merged
merged 55 commits into from
Jan 18, 2022
Merged

ci: run github actions on buildjet #1366

merged 55 commits into from
Jan 18, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Jan 12, 2022 •
edited

Changes introduced:

  • Removes CircleCI completely
  • Migrates missing jobs to Github Actions
  • Introduces powerful runners hosted by BuildJet
  • Ensures tests run on all available core (if possible)
  • Deduplicates jobs and tasks in Github Actions
  • Introduces Rust Version and OS Platform Matrix for builds
  • Restores Code Coverage Reports (Tarpaulin/Codecov)
  • Fixes the Documentation job ci: documentation dry-run for PRs. #1383

Rationale:

  • Get this done once and for all
  • Ultimate goal: full required pipeline jobs finish < 20 minutes

Further Information:

      matrix:
        os: [ubuntu-latest, macos-latest]
        rv: [1.57.0, stable]

TODO: @noot please remove CircleCI integration from this repository 🙏🏼 ...

... and adjust the names of the required tests according to this pull-request. 🙏🏼 🙏🏼 🙏🏼

  • Rust / Test
  • Rust / Lint
  • Rust / Audit
  • Rust / Build (ubuntu-latest, 1.57.0)
  • Rust / Build (macos-latest, 1.57.0)

@q9f q9f requested a review from noot January 12, 2022 12:02
@q9f q9f marked this pull request as ready for review January 12, 2022 12:02
@q9f q9f marked this pull request as draft January 12, 2022 12:57
@q9f q9f marked this pull request as ready for review January 12, 2022 13:50
@noot
Copy link
Contributor

noot commented Jan 12, 2022

@q9f the tests looks pretty slow (2 hours!) is there a way to speed them up? the current github actions job takes around 45mins, and the circleci job is even faster (I think 20-30mins)

@q9f q9f changed the title ci: run github actions on os matrix ci: run github actions on buildjet Jan 13, 2022
@q9f q9f marked this pull request as ready for review January 14, 2022 07:25
@q9f q9f mentioned this pull request Jan 14, 2022
Merged
@lemmih lemmih mentioned this pull request Jan 14, 2022
Closed
@q9f q9f requested a review from lemmih as a code owner January 14, 2022 16:01
lemmih
lemmih reviewed Jan 17, 2022
View reviewed changes
Cargo.toml
@@ -69,3 +69,6 @@ commcid = { path = "./utils/commcid" }
forest_vm = { path = "./vm" }
forest_runtime = { path = "./vm/runtime" }
forest_message = { path = "./vm/message" }

[profile.dev]
debug = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this improve build times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unless you need debug symbols.

I found this article helpful: https://matklad.github.io/2021/09/04/fast-rust-builds.html

@q9f
Copy link
Contributor Author

q9f commented Jan 17, 2022

This is good to go now.

@noot please adjust the names of the required tests according to this pull-request.

  • Rust / Test
  • Rust / Lint
  • Rust / Audit
  • Rust / Build (ubuntu-latest, 1.57.0)
  • Rust / Build (macos-latest, 1.57.0)

@q9f q9f merged commit 250e27a into main Jan 18, 2022
@q9f q9f deleted the q9f/ci/matrix branch January 18, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih left review comments

@noot noot noot approved these changes

@connormullett connormullett Awaiting requested review from connormullett

@ec2 ec2 Awaiting requested review from ec2

@elmattic elmattic Awaiting requested review from elmattic

Assignees
No one assigned
Labels
Maintenance Priority: 4 - Low Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@q9f @noot @lemmih