Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add David to repo maintainers #1374

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Add David to repo maintainers #1374

merged 4 commits into from
Jan 14, 2022

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Jan 13, 2022 •
edited

Summary of changes
Changes introduced in this pull request:

  • Add David to GitHub CODEOWNERS file
  • Remove Jorge
  • Fix some clippy errors

Reference issue to close (if applicable)

Other information and links

@noot
Copy link
Contributor

noot commented Jan 14, 2022

@elmattic I guess the latest rust got updated and now clippy's upset :(

@q9f
Copy link
Contributor

q9f commented Jan 14, 2022 •
edited

I added a clippy ignore to #1366 to deal with this in later in a subsequent PR.

cargo clippy -- -D warnings -A clippy::redundant-clone -A clippy::to-string-in-format-args

edit: #1378

@lemmih
Copy link
Contributor

lemmih commented Jan 14, 2022 •
edited

Sigh, hit the flaky test. Rerunning the tests, hoping for better RNG.

@q9f q9f merged commit 4fc4684 into main Jan 14, 2022
@q9f q9f deleted the elmattic/add_new_codeowner branch January 14, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

@q9f q9f q9f approved these changes

@connormullett connormullett Awaiting requested review from connormullett

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elmattic @noot @q9f @lemmih