Sector types #294
Merged
Sector types #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
approved these changes
Mar 21, 2020
| pub sealed_cid: Cid, | ||
| } | ||
|
|
||
| // TODO docs |
There was a problem hiding this comment.
I notice we have similar types in ticket.rs can we remove them there or are they used differently?
There was a problem hiding this comment.
yeah, I had a look, either they are different types or the ones that existed are now out of date, either way we will find out and remove if there is the connection (inevitably will not be missed later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
I'm not going to say that this was the most boring PR to make, but I also don't want to lie to you
Reference issue to close (if applicable)
Closes #277
Other information and links