Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor annotated serializations #295

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Thought of a cleaner way to override serialization through changes in Sector types #294 so I'm making it here to clean up the standard usage and remove the need to declare temporary types

Idk I think it's so cool what you can do with rust and serde here to make things very clean and efficient

Reference issue to close (if applicable)

Closes

Other information and links

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked more boring than the other one lol

@austinabell
Copy link
Contributor Author

looked more boring than the other one lol

Noo because it's doing new things rather than creating a bunch of types. Plus destructuring that wrapper inside of the tuple destructure to deserialize in oneline without the interim struct is pretty neato if you ask me !

@austinabell austinabell merged commit 3173812 into master Mar 23, 2020
@austinabell austinabell deleted the austin/serializationrefactor branch March 23, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding hashing and serialization Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants