Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NV23 Waffle support 🧇 #4473

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jul 2, 2024

Summary of changes

💛 Sorry for a relatively large PR, I was not confident in the changes until they were all working together with a NV23-compatible Lotus.

Changes introduced in this pull request:

  • FIP-0085 migration,
  • FIP-0091 consensus implementation,
  • Butterflynet, Devnet and Calibnet upgrade with required bundles and assets,
  • Introduced a common type for EthChainId to unify it's usage,
  • integrated v14 actors,
  • renamed Aussie to Waffle as the network upgrade codename

Reference issue to close (if applicable)

Closes #4366
Part of #4318

Other information and links

Tests done on:

TODO

  • Assert correct calibnet state after the upgrade,
# Lotus v1.28.0-rc.1
2024-07-04T15:24:04.479+0200    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "1759060", "from": "bafy2bzacebop56rpqe3ag6fwwzuqiktjdlfkutxbpuhvucyjeugwezvj22ypq", "to": "bafy2bzaceb7wforg3w3g4sauo6vn6gtmon74jegjjv4quvxnuxe326dhr2tqo", "duration": 0.437529503}

# Forest
2024-07-04T13:23:41.775935Z  INFO compute_tipset_state_blocking: forest_filecoin::state_migration: State migration at height Waffle(epoch 1759060) was successful, Previous state: bafy2bzacebop56rpqe3ag6fwwzuqiktjdlfkutxbpuhvucyjeugwezvj22ypq, new state: bafy2bzaceb7wforg3w3g4sauo6vn6gtmon74jegjjv4quvxnuxe326dhr2tqo, new state actors: bafy2bzaceaem6dns4klmosw5be5rbodyqfkrieeg65rhouj7eivawqqiejzoq. Took: 0.677725s.
  • Legacy Ethereum transactions on Butterflynet - Homestead, EIP-155 and EIP-1559 are correctly identified and consensus was held after tests with FilOz.
  • Cleanup code, add more tests for legacy Ethereum transactions.
  • Add relevant docs and links
  • Prepare a release + comms (follow-up)

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs mentioned this pull request Jul 2, 2024
4 tasks
@elmattic elmattic changed the title feat: NV23 Waffle support feat: NV23 Waffle support 🧇 Jul 2, 2024
@LesnyRumcajs LesnyRumcajs force-pushed the fip-0091-eth-legacy-txs branch 11 times, most recently from dc5ae15 to 558c074 Compare July 4, 2024 13:36
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review July 4, 2024 13:36
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner July 4, 2024 13:36
@LesnyRumcajs LesnyRumcajs requested review from lemmih and hanabi1224 and removed request for a team July 4, 2024 13:36
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 8f8dbdc Jul 4, 2024
28 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fip-0091-eth-legacy-txs branch July 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement FIP-0091
3 participants