Implement Block header json #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alize, and havent tested anything
…alization for things like Vec<T> or Option<T>
austinabell
requested review from
timvermeulen,
StaticallyTypedAnxiety,
flodesi and
RajarupanSampanthan
ec2
approved these changes
Jun 2, 2020
Merged
dutterbutter
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Some of this seems like it would be beneficial to be gen from a macro, but there is a bit of inconsistency with how things are serialized that it would just be more work to enable. I did create a shared lib for the Visitor for handling the weird go default json marshalling.
Reference issue to close (if applicable)
Closes #437
Other information and links