InitActor framework #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ec2,
ansermino,
GregTheGreek and
dutterbutter
ansermino
reviewed
Dec 7, 2019
| // TODO revisit on complete spec | ||
| pub const METHOD_PLACEHOLDER: isize = 3; | ||
|
|
||
| pub struct MethodParams(pub Vec<u8>); // TODO |
There was a problem hiding this comment.
I did so because the vector will need to be pulled from the MethodParams when the functionality is implemented. It's possible in the future this can be removed in favour of implemented functions, but it will be a headache if this is kept private in the near future
| @@ -11,6 +11,7 @@ use encoding::{blake2b_variable, Cbor, CodecProtocol, Error as EncodingError}; | |||
| use leb128; | |||
| use serde_cbor::Value::Bytes; | |||
| use serde_cbor::{from_slice, to_vec}; | |||
| use std::hash::Hash; | |||
ec2
approved these changes
Dec 9, 2019
dutterbutter
approved these changes
Dec 9, 2019
|
@GregTheGreek @ansermino you guys good with this coming in? |
GregTheGreek
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now since the other types and implementations aren't built out, this can't be tested. Once it is able to be tested I will test functionality.
If anyone want's to review let me know and I won't make changes but I might tweak some things over the weekend and build on top of this if not, but will try to keep this PR as contained as possible.