Refactor Message type and vm packages #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
changed the title
austinabell
requested review from
GregTheGreek,
dutterbutter,
ansermino and
ec2
This was referenced Dec 10, 2019
ec2
reviewed
Dec 10, 2019
| } | ||
|
|
||
| impl Cbor for SignedMessage { | ||
| fn unmarshal_cbor(_bz: &[u8]) -> Result<Self, EncodingError> { |
There was a problem hiding this comment.
BTW, I dont know if it suits this usecase exactly, but there is an unimplemented! macro.
There was a problem hiding this comment.
yeah, I'm just keeping it as an error so it is recoverable and doesn't crash everything when something is attempted to be encoded/decoded
There was a problem hiding this comment.
Also, encoding/decoding shouldn't cause a panic, parent function should deal with it
ec2
approved these changes
Dec 10, 2019
dutterbutter
approved these changes
Dec 10, 2019
|
@ec2 @dutterbutter moved the CodeID type to the actor crate |
|
@ansermino @GregTheGreek pls review if you can, holding up Dustin and a few of my PRs |
GregTheGreek
approved these changes
Dec 11, 2019
vmx
pushed a commit
to dignifiedquire/forest
that referenced
this pull request
Mar 19, 2020
…hainSafe#79) * feat(bellman): use bellman lib which uses env to disable/enable GPU * feat(addpiece): update add_piece call site to conform to new API * feat(addpiece): update add_piece call site to conform to new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Refactored the vm components into crates also in this PR to get those changes in ASAP. This will be important to do now to not have conflicts and an extremely complicated refactor later. If you look at the structure, the vm crate is primarily used for the vm types currently and the logic and functionality and types used commonly in other packages (message, address) into their own package.
Message refactor info:
After building out the System actors it became apparent that there needs to be some slight changes to the message types and there will probably be a need to iterate over ambiguously signed and unsigned messages.
This moves the Message struct to UnsignedMessage and adds a Message trait which both signed and unsigned messages will implement. Ideally, you would be able to iterate over signed messages and unsigned messages seperately, but if you need to iterate over both types at once (for readability and reduce redundancy) you can just iterate over a pointer to this Message trait implementation.