Updated blocks crate to reflect spec changes #86
Conversation
* Refactored block.rs to reflect spec changes * Added TxMeta struct and replaced messages within blockheader to this type * Added bls_signature to block header with type Signature * Added ElectionPoStVerifyInfo and its required field structs * Made runtime public in order to use ChainEpoch type * Added Clone, Debug and PartialEq derive to ChainEpoch type in runtime for tipset validation * Updated tipset test to reflect struct changes * Added bls and secp message types to TxMeta struct:
dutterbutter
requested review from
austinabell,
GregTheGreek,
ansermino and
ec2
|
The build will fix itself when #87 comes in |
|
@dutterbutter Conflicts |
* Updated comment * removed height
| /// ElectionPoStVerifyInfo seems to be connected to VRF | ||
| /// see https://github.com/filecoin-project/lotus/blob/master/chain/sync.go#L1099 | ||
| struct ElectionPoStVerifyInfo { | ||
| candidates: PoStCandidate, | ||
| randomness: PoStRandomness, | ||
| proof: PoStProof, |
There was a problem hiding this comment.
unused, what is the point of this?
There was a problem hiding this comment.
See comment made in PR conversation, basically, it's defined in the spec and so I figured I would include it as a stubbed structure until we understand its purpose.
There was a problem hiding this comment.
I'll leave to others opinions but this seems weird to stub out a type that may change and is not used
There was a problem hiding this comment.
Yeah, I am impartial I can remove it if that's the popular opinion.
There was a problem hiding this comment.
Id remove it. But also impartial lol
* Stubbed block scoped ChainEpoch type and removed runtime dependency * made comment on unused structures
|
Will wait to merge until #79 comes in to reflect |
* Resolved conflicts; merged in master * Updated Block struct to include UnSignedMessage * Removed ChainEpoch stub for clock::ChainEpoch * Added new fn for impl ChainEpoch to be used publicly for tipset tests
|
@austinabell @ansermino @GregTheGreek @ec2 updated to reflect #79 |
Changes introduced in this PR:
TxMetastruct and replaced messages within blockheader to this typebls_signatureto block header with typeSignatureElectionPoStVerifyInfoand its required field structsChainEpochtypeClone, Debug and PartialEqderive toChainEpochtype in runtime for tipset validationTxMetastructNot exactly sure what
ElectionPoStVerifyInfois responsible for, added in the comment what I assume its related to but since the spec has it included in the block component I have included it there.Closes #80