fix: don't panic if we fail to convert hex to bytes (#3734)

ChainSafe · Feb 2, 2024 · 12234de · 12234de
1 parent 8d46333
commit 12234de
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/dot/state/storage_notify.go b/dot/state/storage_notify.go
@@ -111,7 +111,11 @@ func (s *StorageState) notifyObserver(root common.Hash, o Observer) error {
 	} else {
 		// filter result to include only interested keys
 		for k, cachedValue := range o.GetFilter() {
-			value := t.Get(common.MustHexToBytes(k))
+			bytes, err := common.HexToBytes(k)
+			if err != nil {
+				return fmt.Errorf("failed to convert hex to bytes: %s", err)
+			}
+			value := t.Get(bytes)
 			if !reflect.DeepEqual(cachedValue, value) {
 				kv := &KeyValue{
 					Key:   common.MustHexToBytes(k),