fix(ci): fix all Deepsource issues (#3046)

dot/rpc/json2/server.go

@@ -219,7 +219,7 @@ func (c *CodecRequest) WriteError(w http.ResponseWriter, _ int, err error) {
 	c.writeServerResponse(w, res)
 }
 
-func (c CodecRequest) tryToMapIfNotAnErrorAlready(err error) error {
+func (c *CodecRequest) tryToMapIfNotAnErrorAlready(err error) error {
 	if _, ok := err.(*json2.Error); ok || c.errorMapper == nil {
 		return err
 	}

dot/rpc/modules/childstate_test.go

@@ -124,7 +124,6 @@ func TestChildStateModule_GetKeys(t *testing.T) {
 					Hash: &common.Hash{},
 				},
 			},
-			exp:    []string{},
 			expErr: errors.New("GetStorageChild error"),
 		},
 		{
@@ -138,7 +137,6 @@ func TestChildStateModule_GetKeys(t *testing.T) {
 					Key: []byte(":child_storage_key"),
 				},
 			},
-			exp:    []string{},
 			expErr: errors.New("GetStateRootFromBlock error"),
 		},
 	}
@@ -148,7 +146,7 @@ func TestChildStateModule_GetKeys(t *testing.T) {
 				storageAPI: tt.fields.storageAPI,
 				blockAPI:   tt.fields.blockAPI,
 			}
-			res := []string{}
+			var res []string
 			err := cs.GetKeys(tt.args.in0, tt.args.req, &res)
 			if tt.expErr != nil {
 				assert.EqualError(t, err, tt.expErr.Error())

dot/rpc/modules/system_test.go

@@ -446,14 +446,13 @@ func TestSystemModule_LocalListenAddresses(t *testing.T) {
 			args: args{
 				req: &EmptyRequest{},
 			},
-			exp:    []string{},
 			expErr: errors.New("multiaddress list is empty"),
 		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			sm := tt.sysModule
-			res := []string{}
+			var res []string
 			err := sm.LocalListenAddresses(tt.args.r, tt.args.req, &res)
 			if tt.expErr != nil {
 				assert.EqualError(t, err, tt.expErr.Error())

dot/types/babe_digest.go

@@ -57,8 +57,8 @@ func NewBabePrimaryPreDigest(authorityIndex uint32,
 }
 
 // ToPreRuntimeDigest returns the BabePrimaryPreDigest as a PreRuntimeDigest
-func (d *BabePrimaryPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
-	return toPreRuntimeDigest(*d)
+func (d BabePrimaryPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
+	return toPreRuntimeDigest(d)
 }
 
 // Index returns VDT index
@@ -85,8 +85,8 @@ func NewBabeSecondaryPlainPreDigest(authorityIndex uint32, slotNumber uint64) *B
 }
 
 // ToPreRuntimeDigest returns the BabeSecondaryPlainPreDigest as a PreRuntimeDigest
-func (d *BabeSecondaryPlainPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
-	return toPreRuntimeDigest(*d)
+func (d BabeSecondaryPlainPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
+	return toPreRuntimeDigest(d)
 }
 
 // Index returns VDT index
@@ -118,8 +118,8 @@ func NewBabeSecondaryVRFPreDigest(authorityIndex uint32,
 }
 
 // ToPreRuntimeDigest returns the BabeSecondaryVRFPreDigest as a PreRuntimeDigest
-func (d *BabeSecondaryVRFPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
-	return toPreRuntimeDigest(*d)
+func (d BabeSecondaryVRFPreDigest) ToPreRuntimeDigest() (*PreRuntimeDigest, error) {
+	return toPreRuntimeDigest(d)
 }
 
 // Index returns VDT index

dot/types/body.go

@@ -24,12 +24,11 @@ func NewBody(e []Extrinsic) *Body {
 
 // NewBodyFromBytes returns a Body from a SCALE encoded byte array.
 func NewBodyFromBytes(b []byte) (*Body, error) {
-	exts := [][]byte{}
-
 	if len(b) == 0 {
 		return NewBody([]Extrinsic{}), nil
 	}
 
+	var exts [][]byte
 	err := scale.Unmarshal(b, &exts)
 	if err != nil {
 		return nil, err
@@ -59,16 +58,15 @@ func NewBodyFromEncodedBytes(exts [][]byte) (*Body, error) {
 
 // NewBodyFromExtrinsicStrings creates a block body given an array of hex-encoded
 // 0x-prefixed strings.
-func NewBodyFromExtrinsicStrings(ss []string) (*Body, error) {
-	exts := []Extrinsic{}
-	for _, s := range ss {
-		b, err := common.HexToBytes(s)
+func NewBodyFromExtrinsicStrings(ss []string) (body *Body, err error) {
+	exts := make([]Extrinsic, len(ss))
+	for i, s := range ss {
+		exts[i], err = common.HexToBytes(s)
 		if errors.Is(err, common.ErrNoPrefix) {
-			b = []byte(s)
+			exts[i] = []byte(s)
 		} else if err != nil {
 			return nil, err
 		}
-		exts = append(exts, b)
 	}
 
 	return NewBody(exts), nil

dot/types/body_test.go

@@ -4,7 +4,6 @@
 package types
 
 import (
-	"fmt"
 	"testing"
 
 	"github.com/ChainSafe/gossamer/lib/common"
@@ -48,14 +47,11 @@ func TestBodyFromEncodedBytes(t *testing.T) {
 }
 
 func TestBodyFromExtrinsicStrings(t *testing.T) {
-	extStrings := []string{}
-
-	for _, ext := range exts {
-		extStrings = append(extStrings, common.BytesToHex(ext))
+	extStrings := make([]string, len(exts))
+	for i := range exts {
+		extStrings[i] = common.BytesToHex(exts[i])
 	}
 
-	fmt.Println(extStrings)
-
 	bodyFromByteExtrinsics := NewBody(exts)
 	bodyFromStringExtrinsics, err := NewBodyFromExtrinsicStrings(extStrings)
 	require.NoError(t, err)

dot/types/consensus_digest.go

@@ -95,14 +95,14 @@ type NextEpochData struct {
 }
 
 // Index returns VDT index
-func (NextEpochData) Index() uint { return 1 }
+func (NextEpochData) Index() uint { return 1 } //skipcq: GO-W1029
 
-func (d NextEpochData) String() string {
+func (d NextEpochData) String() string { //skipcq: GO-W1029
 	return fmt.Sprintf("NextEpochData Authorities=%v Randomness=%v", d.Authorities, d.Randomness)
 }
 
 // ToEpochData returns the NextEpochData as EpochData
-func (d *NextEpochData) ToEpochData() (*EpochData, error) {
+func (d *NextEpochData) ToEpochData() (*EpochData, error) { //skipcq: GO-W1029
 	auths, err := BABEAuthorityRawToAuthority(d.Authorities)
 	if err != nil {
 		return nil, err
@@ -135,15 +135,15 @@ type NextConfigData struct {
 }
 
 // Index returns VDT index
-func (NextConfigData) Index() uint { return 3 }
+func (NextConfigData) Index() uint { return 3 } //skipcq: GO-W1029
 
-func (d NextConfigData) String() string {
+func (d NextConfigData) String() string { //skipcq: GO-W1029
 	return fmt.Sprintf("NextConfigData{C1=%d, C2=%d, SecondarySlots=%d}",
 		d.C1, d.C2, d.SecondarySlots)
 }
 
 // ToConfigData returns the NextConfigData as ConfigData
-func (d *NextConfigData) ToConfigData() *ConfigData {
+func (d *NextConfigData) ToConfigData() *ConfigData { //skipcq: GO-W1029
 	return &ConfigData{
 		C1:             d.C1,
 		C2:             d.C2,

dot/types/grandpa.go

@@ -149,7 +149,7 @@ func EncodeGrandpaVoters(voters GrandpaVoters) ([]byte, error) {
 
 // DecodeGrandpaVoters returns a decoded GrandpaVoters
 func DecodeGrandpaVoters(in []byte) (GrandpaVoters, error) {
-	dec := []voter{}
+	var dec []voter
 	err := scale.Unmarshal(in, &dec)
 	if err != nil {
 		return nil, err

dot/types/grandpa_test.go

@@ -68,7 +68,7 @@ func TestGrandpaAuthoritiesRawToAuthorities(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, exp, enc)
 
-	dec := []GrandpaAuthoritiesRaw{}
+	var dec []GrandpaAuthoritiesRaw
 	err = scale.Unmarshal(enc, &dec)
 	require.NoError(t, err)
 	require.Equal(t, auths, dec)

dot/types/inherents.go

@@ -98,7 +98,7 @@ func (d *InherentData) Encode() ([]byte, error) {
 		return nil, err
 	}
 
-	keys := [][8]byte{}
+	keys := make([][8]byte, 0, len(d.Data))
 	for key := range d.Data {
 		keys = append(keys, key)
 	}

internal/pprof/settings.go

@@ -24,7 +24,7 @@ func (s *Settings) setDefaults() {
 	}
 }
 
-func (s Settings) String() string {
+func (s *Settings) String() string {
 	return fmt.Sprintf(
 		"listening on %s and setting block profile rate to %d, mutex profile rate to %d",
 		s.ListeningAddress, s.BlockProfileRate, s.MutexProfileRate)

internal/trie/node/copy.go

@@ -53,7 +53,7 @@ type CopySettings struct {
 // Copy deep copies the node.
 // Setting copyChildren to true will deep copy
 // children as well.
-func (n *Node) Copy(settings CopySettings) *Node { //skipcq: GO-W1029
+func (n *Node) Copy(settings CopySettings) *Node {
 	cpy := &Node{
 		Dirty:       n.Dirty,
 		Generation:  n.Generation,

internal/trie/node/node.go

@@ -52,7 +52,7 @@ func (n *Node) String() string {
 }
 
 // StringNode returns a gotree compatible node for String methods.
-func (n Node) StringNode() (stringNode *gotree.Node) {
+func (n *Node) StringNode() (stringNode *gotree.Node) {
 	caser := cases.Title(language.BritishEnglish)
 	stringNode = gotree.New(caser.String(n.Kind().String()))
 	stringNode.Appendf("Generation: %d", n.Generation)

internal/trie/node/subvalue.go

@@ -8,7 +8,7 @@ import "bytes"
 // StorageValueEqual returns true if the node storage value is equal to the
 // storage value given as argument. In particular, it returns false
 // if one storage value is nil and the other storage value is the empty slice.
-func (n Node) StorageValueEqual(stoageValue []byte) (equal bool) {
+func (n *Node) StorageValueEqual(stoageValue []byte) (equal bool) {
 	if len(stoageValue) == 0 && len(n.StorageValue) == 0 {
 		return (stoageValue == nil && n.StorageValue == nil) ||
 			(stoageValue != nil && n.StorageValue != nil)

lib/blocktree/leaves.go

@@ -111,7 +111,7 @@ func (lm *leafMap) nodes() []*node {
 	lm.RLock()
 	defer lm.RUnlock()
 
-	nodes := []*node{}
+	var nodes []*node
 
 	lm.smap.Range(func(h, n interface{}) bool {
 		node := n.(*node)

lib/blocktree/node_test.go

@@ -23,7 +23,7 @@ func TestNode_GetLeaves(t *testing.T) {
 	testNode := bt.getNode(branches[0].hash).children[0]
 	leaves := testNode.getLeaves(nil)
 
-	expected := []*node{}
+	var expected []*node
 	for _, lf := range bt.leaves.toMap() {
 		if lf.isDescendantOf(testNode) {
 			expected = append(expected, lf)

lib/common/common.go

@@ -17,9 +17,8 @@ import (
 var ErrNoPrefix = errors.New("could not byteify non 0x prefixed string")
 
 // StringToInts turns a string consisting of ints separated by commas into an int array
-func StringToInts(in string) ([]int, error) {
+func StringToInts(in string) (res []int, err error) {
 	intstrs := strings.Split(in, ",")
-	res := []int{}
 	for _, intstr := range intstrs {
 		i, err := strconv.Atoi(intstr)
 		if err != nil {
@@ -32,18 +31,18 @@ func StringToInts(in string) ([]int, error) {
 
 // StringArrayToBytes turns an array of strings into an array of byte arrays
 func StringArrayToBytes(in []string) [][]byte {
-	b := [][]byte{}
-	for _, str := range in {
-		b = append(b, []byte(str))
+	b := make([][]byte, len(in))
+	for i := range in {
+		b[i] = []byte(in[i])
 	}
 	return b
 }
 
 // BytesToStringArray turns an array of byte arrays into an array strings
 func BytesToStringArray(in [][]byte) []string {
-	strs := []string{}
-	for _, b := range in {
-		strs = append(strs, string(b))
+	strs := make([]string, len(in))
+	for i := range in {
+		strs[i] = string(in[i])
 	}
 	return strs
 }

lib/common/hash.go

@@ -30,7 +30,7 @@ func NewHash(in []byte) (res Hash) {
 }
 
 // ToBytes turns a hash to a byte array
-func (h Hash) ToBytes() []byte {
+func (h Hash) ToBytes() []byte { //skipcq: GO-W1029
 	b := [32]byte(h)
 	return b[:]
 }
@@ -49,24 +49,24 @@ func HashValidator(field reflect.Value) interface{} {
 }
 
 // IsEmpty returns true if the hash is empty, false otherwise.
-func (h Hash) IsEmpty() bool {
+func (h Hash) IsEmpty() bool { //skipcq: GO-W1029
 	return h == Hash{}
 }
 
 // String returns the hex string for the hash
-func (h Hash) String() string {
+func (h Hash) String() string { //skipcq: GO-W1029
 	return fmt.Sprintf("0x%x", h[:])
 }
 
 // Short returns the first 4 bytes and the last 4 bytes of the hex string for the hash
-func (h Hash) Short() string {
+func (h Hash) Short() string { //skipcq: GO-W1029
 	const nBytes = 4
 	return fmt.Sprintf("0x%x...%x", h[:nBytes], h[len(h)-nBytes:])
 }
 
 // SetBytes sets the hash to the value of b.
 // If b is larger than len(h), b will be cropped from the left.
-func (h *Hash) SetBytes(b []byte) {
+func (h *Hash) SetBytes(b []byte) { //skipcq: GO-W1029
 	if len(b) > len(h) {
 		b = b[len(b)-HashLength:]
 	}
@@ -95,7 +95,7 @@ func BytesToHash(b []byte) Hash {
 }
 
 // UnmarshalJSON converts hex data to hash
-func (h *Hash) UnmarshalJSON(data []byte) error {
+func (h *Hash) UnmarshalJSON(data []byte) error { //skipcq: GO-W1029
 	trimmedData := strings.Trim(string(data), "\"")
 	if len(trimmedData) < 2 {
 		return errors.New("invalid hash format")
@@ -109,7 +109,7 @@ func (h *Hash) UnmarshalJSON(data []byte) error {
 }
 
 // MarshalJSON converts hash to hex data
-func (h Hash) MarshalJSON() ([]byte, error) {
+func (h Hash) MarshalJSON() ([]byte, error) { //skipcq: GO-W1029
 	return json.Marshal(h.String())
 }
 

lib/common/hasher_test.go

@@ -14,7 +14,7 @@ import (
 func TestBlake2b218_EmptyHash(t *testing.T) {
 	// test case from https://github.com/noot/blake2b_test which uses the blake2-rfp rust crate
 	// also see https://github.com/paritytech/substrate/blob/master/core/primitives/src/hashing.rs
-	in := []byte{}
+	var in []byte
 	h, err := common.Blake2b128(in)
 	require.NoError(t, err)
 
@@ -42,7 +42,7 @@ func Test_MustBlake2b8(t *testing.T) {
 func TestBlake2bHash_EmptyHash(t *testing.T) {
 	// test case from https://github.com/noot/blake2b_test which uses the blake2-rfp rust crate
 	// also see https://github.com/paritytech/substrate/blob/master/core/primitives/src/hashing.rs
-	in := []byte{}
+	var in []byte
 	h, err := common.Blake2bHash(in)
 	require.NoError(t, err)
 
@@ -53,7 +53,7 @@ func TestBlake2bHash_EmptyHash(t *testing.T) {
 
 func TestKeccak256_EmptyHash(t *testing.T) {
 	// test case from https://github.com/debris/tiny-keccak/blob/master/tests/keccak.rs#L4
-	in := []byte{}
+	var in []byte
 	h, err := common.Keccak256(in)
 	require.NoError(t, err)
 

lib/keystore/basic_keystore.go

@@ -82,8 +82,7 @@ func (ks *BasicKeystore) GetKeypairFromAddress(pub common.Address) KeyPair {
 }
 
 // PublicKeys returns all public keys in the keystore
-func (ks *BasicKeystore) PublicKeys() []crypto.PublicKey {
-	srkeys := []crypto.PublicKey{}
+func (ks *BasicKeystore) PublicKeys() (srkeys []crypto.PublicKey) {
 	if ks.keys == nil {
 		return srkeys
 	}