Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/network: open BlockAnnounce stream and send handshake on connect #1425

Closed
noot opened this issue Feb 28, 2021 · 0 comments · Fixed by #1467
Closed

dot/network: open BlockAnnounce stream and send handshake on connect #1425

noot opened this issue Feb 28, 2021 · 0 comments · Fixed by #1467
Assignees
@noot

Comments

@noot
Copy link
Contributor

noot commented Feb 28, 2021

Task summary

  • when a node dials another node, it should open a BlockAnnounce stream when it connects and send a handshake
  • this should prevent the case where it takes a while to bootstrap, since we are waiting for other nodes to dial us
  • also, in the case of a node being run on a mcahine that doesn't allow inbound connectons, it will never be able to start syncing

related to #1134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat:dot/network: open block announce stream and send handshake on connect ChainSafe/gossamer
2 participants
@dutterbutter @noot