feat:dot/network: open block announce stream and send handshake on connect #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1467 +/- ##
===============================================
+ Coverage 58.01% 58.15% +0.13%
===============================================
Files 152 152
Lines 15307 15327 +20
===============================================
+ Hits 8881 8914 +33
+ Misses 4874 4862 -12
+ Partials 1552 1551 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
RyRy79261
approved these changes
Mar 16, 2021
edwardmack
approved these changes
Mar 16, 2021
arijitAD
reviewed
Mar 17, 2021
dot/network/service.go
Outdated
| s.notificationsMu.Lock() | ||
| defer s.notificationsMu.Unlock() | ||
|
|
||
| if _, has := s.notificationsProtocols[BlockAnnounceMsgType]; !has { |
There was a problem hiding this comment.
Avoid refetching BlockAnnounceMsgType from map.
info, has := s.notificationsProtocols[BlockAnnounceMsgType]
if !has {
....
}
| peer := conn.RemotePeer() | ||
| if hsData, has := info.handshakeData[peer]; !has || !hsData.received { | ||
| info.handshakeData[peer] = &handshakeData{ | ||
| validated: false, |
There was a problem hiding this comment.
Should we set also set received to true or reuse the hsData?
There was a problem hiding this comment.
no, at this point it hasn't sent or received any handshakes
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
noot: feat:dot/network: open block announce stream and send handshake on connect (#1467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues