Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess and refactor time intensive unit-tests #1472

Closed
dutterbutter opened this issue Mar 17, 2021 · 4 comments
Closed

Assess and refactor time intensive unit-tests #1472

dutterbutter opened this issue Mar 17, 2021 · 4 comments
Assignees
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@dutterbutter
Copy link
Contributor

dutterbutter commented Mar 17, 2021

Issue summary

  • Improve the speed of certain tests by assessing if resources can be shared, move to parallel table driven tests, or the use of gomock
  • Below is a table of the longest taking unit test packages
Package Time taken
github.com/ChainSafe/gossamer/dot ~350.508s
github.com/ChainSafe/gossamer/dot/core ~311.674s
github.com/ChainSafe/gossamer/lib/babe ~571.752s
github.com/ChainSafe/gossamer/dot/sync ~297.813s
github.com/ChainSafe/gossamer/lib/runtime/wasmer ~225.374s
github.com/ChainSafe/gossamer/dot/rpc/modules ~614.548s

Other information and links

@noot noot changed the title Assess and refactor long taking unit-tests Assess and refactor time intensive unit-tests May 6, 2021
@dutterbutter dutterbutter added p2 and removed p3 labels May 18, 2021
@timwu20 timwu20 added the Epic Issue used to track development status of a complex feature, aggregates several issues label Oct 4, 2021
@danforbes
Copy link
Contributor

danforbes commented Jan 7, 2022

As of 2022-01-07 our unit tests are taking about 30 min to complete (ref: CI for #2142); when this Epic was created, unit tests were running in about 25 min (ref: CI for #1471)

Package Time taken
github.com/ChainSafe/gossamer/dot ~363.234s (increased)
github.com/ChainSafe/gossamer/dot/core ~356.770s (increased)
github.com/ChainSafe/gossamer/lib/babe ~466.412s (decreased 🎉)
github.com/ChainSafe/gossamer/dot/sync ~151.814s (decreased 🎉)
github.com/ChainSafe/gossamer/lib/runtime/wasmer ~196.737s (decreased 🎉)
github.com/ChainSafe/gossamer/dot/rpc/modules ~0.417s (decreased BIGLY 🎉 🎉 🎉)

@noot
Copy link
Contributor

noot commented Mar 17, 2022

@danforbes what's the status on this?

@danforbes
Copy link
Contributor

My understanding is that @edwardmack is actively working on Issues that should fall under this Epic. @timwu20 do you have any thoughts on a "definition of done" for this Epic?

@timwu20
Copy link
Contributor

timwu20 commented Nov 22, 2023

I believe we've made good progress on this. We should create a new epic to track this effort for any remaining packages.

@timwu20 timwu20 closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Development

No branches or pull requests

4 participants