(dot/network) testStreamHandler use a notify channel to remove time.Sleep in tests

[EclesioMeloJunior]

Issue summary

• I noticed that in all tests whose uses testStreamHandler has a time.Sleep(time.Second) to wait for the messages sent to the stream handler to arrive and then call the asserts to check.
• However, is it possible to testStreamHandler struct has a field messageArrived chan<- struct{} that always a message is arrived sent a message to the test to unblock and exec the tests without time.Sleep(...)

Other information and links

type testStreamHandler struct {
	messageArrived <-chan struct{}
        ...
}

func (s *testStreamHandler) handleMessage(stream libp2pnetwork.Stream, msg Message) error {
	s.messageArrived <- struct{}
	...
}

In the test side

func Test_...(t *testing.T) {
	...
        + handlerMessageArrived := make(chan struct{})
        + handler := newTestStreamHandler(testBlockRequestMessageDecoder, handlerMessageArrived)
        ...
        - time.Sleep(time.Second)
        + <-handlerMessageArrived

        msg, ok := handler.messages[nodeA.host.id()]
	require.True(t, ok)
	require.Equal(t, 1, len(msg))
	require.Equal(t, testBlockReqMessage, msg[0])
}

[EclesioMeloJunior]

@qdm12 @danforbes can this issue be related to tests epic?

[qdm12]

Yes you can move it there for now. @danforbes when would you like to convert the testing plan/what we discussed into epics? That would fall under the make our test test suite faster epic I think.

[danforbes]

@qdm12 do you mean #1472?

[qdm12]

Exactly! I assigned the issue to the 1472 epic