Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non authority node fails to handle block announce message. #1538

Closed
arijitAD opened this issue Apr 22, 2021 · 2 comments · Fixed by #1545
Closed

Non authority node fails to handle block announce message. #1538

arijitAD opened this issue Apr 22, 2021 · 2 comments · Fixed by #1545
Assignees
@arijitAD

Comments

@arijitAD
Copy link
Contributor

arijitAD commented Apr 22, 2021 •
edited
Loading

Issue summary

  • Non-authority node fails to read block announce message.

Other information and links
@arijitAD arijitAD self-assigned this Apr 22, 2021
@noot
Copy link
Contributor

noot commented Apr 22, 2021

@arijitAD is the problem that it doesn't get the full block after receiving the block announce, or that it can't process the full block?

@arijitAD
Copy link
Contributor Author

@arijitAD is the problem that it doesn't get the full block after receiving the block announce, or that it can't process the full block?

The issue has two parts:

  1. Non-authority node reads data from stream incorrectly. (Fixed)
  2. Even after fixing the read, the block announce message is not handled properly. (Currently Investigating)

@arijitAD arijitAD mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arijitAD arijitAD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dot/network): Fix notification handshake and reuse stream. ChainSafe/gossamer
2 participants
@arijitAD @noot