Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/trie: limited parallelism for hashing of nodes #2084

Closed
qdm12 opened this issue Nov 30, 2021 · 0 comments
Closed

lib/trie: limited parallelism for hashing of nodes #2084

qdm12 opened this issue Nov 30, 2021 · 0 comments
Assignees

Comments

@qdm12
Copy link
Contributor

qdm12 commented Nov 30, 2021

Task summary

The current parallel hashing implementation hashes each 16 nodes in parallel and recursively.
This can cause memory pressure on the stack since, although cheap, goroutines are not totally free.

The hashing should be changed to have a limited parallelism, ideally set to the number of CPU cores available.
We should also prioritize parallel hashing of branches to have less context switching and longer lasting goroutines.

Progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant