Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Parachain Inherents #2426

Closed
noot opened this issue Mar 22, 2022 · 1 comment · Fixed by #2566
Closed

Implement Parachain Inherents #2426

noot opened this issue Mar 22, 2022 · 1 comment · Fixed by #2566
Assignees

Comments

@noot
Copy link
Contributor

noot commented Mar 22, 2022

Task summary

  • implement stubbed/empty newheads and parachn0 inherents to allow block building w/ polkadot runtimes >= v0.9.17
  • for now we can use "empty" values, as we require parachain-specific logic to actually provide the data.

Specification reference

newheads inherent type: I don't think this is actually set in polkadot, as searching the codebase for NEW_HEADS_IDENTIFIER doesn't show it being set.

parachn0 inherent type: https://github.com/paritytech/polkadot/blob/v0.9.17/primitives/src/v1/mod.rs#L1345

/// Parachains inherent-data passed into the runtime by a block author
#[derive(Encode, Decode, Clone, PartialEq, RuntimeDebug, TypeInfo)]
pub struct InherentData<HDR: HeaderT = Header> {
	/// Signed bitfields by validators about availability.
	pub bitfields: UncheckedSignedAvailabilityBitfields,
	/// Backed candidates for inclusion in the block.
	pub backed_candidates: Vec<BackedCandidate<HDR::Hash>>,
	/// Sets of dispute votes for inclusion,
	pub disputes: MultiDisputeStatementSet,
	/// The parent block header. Used for checking state proofs.
	pub parent_header: HDR,
}
@danforbes danforbes added W3F Approved and removed p1 labels Apr 15, 2022
@kishansagathiya kishansagathiya self-assigned this Apr 28, 2022
@danforbes danforbes changed the title v0.9.17: implement polkadot inherents Implement Parachain Inherents Apr 29, 2022
@EclesioMeloJunior
Copy link
Member

I found the bitfield-sign crate in the polkadot repository which seems to be responsible to retrieve the bitfield information and check the availability of the cores

@kishansagathiya fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants