Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/network: start syncQueue after bootstrapping, don't run syncQueue during tests #1446

Merged
merged 8 commits into from
Mar 9, 2021
Merged

dot/network: start syncQueue after bootstrapping, don't run syncQueue during tests #1446

merged 8 commits into from
Mar 9, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 8, 2021 •
edited

Changes

  • start syncQueue after bootstrapping (i noticed it would start before the node was done setting up the networking, causing weird behaviour)
  • don't run syncQueue during tests (network tests have been having issues lately, this hopefully will help)

Tests

go test ./dot/network -short

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@noot noot marked this pull request as ready for review March 9, 2021 02:33
@noot noot self-assigned this Mar 9, 2021
arijitAD
arijitAD reviewed Mar 9, 2021
View reviewed changes
dot/network/sync.go Outdated Show resolved Hide resolved
@noot noot merged commit 8dbdb13 into development Mar 9, 2021
@noot noot deleted the noot/fix-sync branch March 9, 2021 19:57
github-actions bot pushed a commit that referenced this pull request Mar 9, 2021
@noot
Deploy docs from 8dbdb13
d286813 
noot: dot/network: start syncQueue after bootstrapping, don't run syncQueue during tests (#1446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arijitAD arijitAD arijitAD approved these changes

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noot @arijitAD @RyRy79261 @dutterbutter