Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: dot: test transfer extrinsic #1448

Merged
merged 12 commits into from
Mar 22, 2021
Merged

test: dot: test transfer extrinsic #1448

merged 12 commits into from
Mar 22, 2021

Conversation

arijitAD
Copy link
Contributor

@arijitAD arijitAD commented Mar 10, 2021

Changes

  • Add TestPendingExtrinsic

Tests


Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@arijitAD arijitAD marked this pull request as draft March 10, 2021 15:00
@arijitAD arijitAD changed the title test(dot) WIP: Test transfer extrinsic. test(dot): WIP: Test transfer extrinsic. Mar 10, 2021
@arijitAD arijitAD changed the title test(dot): WIP: Test transfer extrinsic. test: dot: Test transfer extrinsic. Mar 19, 2021
@arijitAD arijitAD marked this pull request as ready for review March 19, 2021 11:57
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1448 (7833e77) into development (09df0c3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1448      +/-   ##
===============================================
- Coverage        58.61%   58.61%   -0.01%     
===============================================
  Files              151      151              
  Lines            15060    15057       -3     
===============================================
- Hits              8828     8826       -2     
- Misses            4694     4695       +1     
+ Partials          1538     1536       -2     
Flag Coverage Δ
unit-tests 58.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/grandpa/grandpa.go 64.27% <ø> (ø)
dot/rpc/modules/author.go 71.42% <100.00%> (+2.53%) ⬆️
dot/network/notifications.go 53.84% <0.00%> (-9.62%) ⬇️
lib/blocktree/leaves.go 90.24% <0.00%> (-4.88%) ⬇️
dot/network/host.go 72.97% <0.00%> (+1.35%) ⬆️
dot/network/service.go 62.65% <0.00%> (+1.58%) ⬆️
dot/state/block_notify.go 85.18% <0.00%> (+1.85%) ⬆️
dot/network/utils.go 61.53% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09df0c3...7833e77. Read the comment docs.

@dutterbutter dutterbutter changed the title test: dot: Test transfer extrinsic. test: dot: test transfer extrinsic Mar 19, 2021
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! we should open a follow up issue that ensures a transaction sent to a non-authority node is able to add the tx to the pool and gossip it (right now it seems to fail on validation)

@noot noot merged commit 68ac803 into development Mar 22, 2021
@noot noot deleted the transfer-extrinsic-test branch March 22, 2021 15:37
github-actions bot pushed a commit that referenced this pull request Mar 22, 2021
Arijit Das: test: dot: test transfer extrinsic (#1448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction Network Test: transfer
5 participants