Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lib/runtime: allow generic keystore type in public_keys ext functions #1450

Merged
merged 5 commits into from
Mar 12, 2021
Merged

fix: lib/runtime: allow generic keystore type in public_keys ext functions #1450

merged 5 commits into from
Mar 12, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 11, 2021 •
edited

Changes

  • allow generic keystore type in public_keys ext functions (since it may contain any type of key)

Tests

go test ./lib/runtime/wasmer/ -run Test_ext_crypto_ed25519_public_keys_version_1
go test ./lib/runtime/wasmer/ -run Test_ext_crypto_sr25519_public_keys_version_1

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@noot noot self-assigned this Mar 11, 2021
@FlorianFranzen
Copy link
Contributor

Thank you, this fixes the issue for us!

@FlorianFranzen FlorianFranzen mentioned this pull request Mar 11, 2021
Merged
RyRy79261
RyRy79261 previously requested changes Mar 11, 2021
View reviewed changes
lib/runtime/wasmer/imports.go Outdated Show resolved Hide resolved
@noot noot requested a review from RyRy79261 March 11, 2021 16:05
arijitAD
arijitAD approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@arijitAD arijitAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://play.golang.org/p/B4-xirJsSKd
We can implement a custom logger for wasmer package that prints the function name dynamically.

@noot noot merged commit 910b5bf into development Mar 12, 2021
@noot noot deleted the noot/fix-ext-crypto branch March 12, 2021 15:38
github-actions bot pushed a commit that referenced this pull request Mar 12, 2021
@noot
Deploy docs from 910b5bf
f943aa1 
noot: fix: lib/runtime: allow generic keystore type in public_keys ext functions (#1450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen FlorianFranzen approved these changes

@edwardmack edwardmack edwardmack approved these changes

@arijitAD arijitAD arijitAD approved these changes

@RyRy79261 RyRy79261 RyRy79261 approved these changes

Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update runtime keystore to use GlobalKeystore, use key type IDs in ext_crypto funcs
6 participants
@noot @FlorianFranzen @edwardmack @arijitAD @RyRy79261 @dutterbutter