feat: dot/state: implement import-state subcommand #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyRy79261
approved these changes
Mar 12, 2021
arijitAD
reviewed
Mar 12, 2021
| @@ -180,6 +180,18 @@ func (v *VerificationManager) VerifyBlock(header *types.Header) error { | |||
|
|
|||
There was a problem hiding this comment.
We should Unlock above when we return early. (line:168 and line:173)
dot/sync/syncer.go
Outdated
| } | ||
|
|
||
| hasHeader, _ := s.blockState.HasHeader(bd.Hash) | ||
| hasBody, _ := s.blockState.HasBlockBody(bd.Hash) | ||
| if hasHeader && hasBody && bd.Number().Int64() <= bestNum.Int64() { | ||
| if hasHeader && hasBody || bd.Number() != nil && bd.Number().Int64() <= bestNum.Int64() { |
There was a problem hiding this comment.
This is harder to read. Group logical statements in brackets.
dot/state/service.go
Outdated
| DataDir: s.dbPath, | ||
| } | ||
|
|
||
| var err error |
There was a problem hiding this comment.
Move this variable declaration inside the else statement.
dot/state/epoch.go
Outdated
| // SkipVerify returns whether verification for the given header should be skipped or not. | ||
| // Only used in the case of imported state. | ||
| func (s *EpochState) SkipVerify(header *types.Header) (bool, error) { | ||
| skipToEpoch := s.skipToEpoch |
There was a problem hiding this comment.
Can the variable copy avoided?
| entries := make(map[string]string) | ||
| for _, pair := range pairs { | ||
| pairArr := pair.([]interface{}) | ||
| entries[pairArr[0].(string)] = pairArr[1].(string) |
There was a problem hiding this comment.
Can we assert as a safety check that the length of pairArr is always equal to two?
|
@arijitAD comments addressed! |
arijitAD
approved these changes
Mar 12, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2021
noot: feat: dot/state: implement import-state subcommand (#1455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
import-statesubcommand which imports state at a given block and starts the chain at that block when the node is startedTests
I also wrote some docs on how to use the
import-statesubcommand with a substrate archive node: https://hackmd.io/@nZ-twauPRISEa6G9zg3XRw/SJ8BgXOXO please try it and let me know how it goesChecklist
Issues