Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lib/runtime: return 0 on ext_crypto_sr25519_verify_version_2 or ext_crypto_ed25519_verify_version_1 failure, fixes polkadot block 1089328 #1458

Merged
merged 11 commits into from
Mar 15, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 12, 2021

Changes

  • return 0 on ext_crypto_sr25519_verify_version_2 or ext_crypto_ed25519_verify_version_1 failure, fixes polkadot block 1089328

Tests

go test ./lib/runtime/wasmer/ -run TestInstance_ExecuteBlock_PolkadotBlock1089328 

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (development@d0b4077). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1458   +/-   ##
==============================================
  Coverage               ?   57.75%           
==============================================
  Files                  ?      152           
  Lines                  ?    15311           
  Branches               ?        0           
==============================================
  Hits                   ?     8843           
  Misses                 ?     4925           
  Partials               ?     1543           
Flag Coverage Δ
unittests 57.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b4077...f55d619. Read the comment docs.

@noot noot merged commit 7673637 into development Mar 15, 2021
@noot noot deleted the noot/polkadot-block-1089328 branch March 15, 2021 18:43
github-actions bot pushed a commit that referenced this pull request Mar 15, 2021
noot: fix: lib/runtime: return 0 on ext_crypto_sr25519_verify_version_2 or ext_crypto_ed25519_verify_version_1 failure, fixes polkadot block 1089328 (#1458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants