Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:lib/trie: fix trie.NextKey case #1463

Merged
merged 5 commits into from
Mar 16, 2021
Merged

fix:lib/trie: fix trie.NextKey case #1463

merged 5 commits into from
Mar 16, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 15, 2021

Changes

  • the spec team pointed out an issue with the new trie.NextKey function, this fixes that case

Tests

go test ./lib/trie

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (development@7673637). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1463   +/-   ##
==============================================
  Coverage               ?   57.74%           
==============================================
  Files                  ?      152           
  Lines                  ?    15315           
  Branches               ?        0           
==============================================
  Hits                   ?     8843           
  Misses                 ?     4927           
  Partials               ?     1545           
Flag Coverage Δ
unittests 57.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7673637...8a1ad30. Read the comment docs.

@noot noot merged commit 355b5f9 into development Mar 16, 2021
@noot noot deleted the noot/next-key branch March 16, 2021 14:33
github-actions bot pushed a commit that referenced this pull request Mar 16, 2021
noot: fix:lib/trie: fix trie.NextKey case (#1463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants