Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename ksmcc -> kusama #1470

Merged
merged 4 commits into from
Mar 16, 2021
Merged

chore: rename ksmcc -> kusama #1470

merged 4 commits into from
Mar 16, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 16, 2021

Changes

  • rename ksmcc -> kusama

Tests

go test ./cmd/...
make gossamer
./bin/gossamer --chain kusama

Issues

  • n/a

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1470 (957d7b0) into development (34befe0) will increase coverage by 0.03%.
The diff coverage is 3.44%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1470      +/-   ##
===============================================
+ Coverage        57.82%   57.85%   +0.03%     
===============================================
  Files              152      152              
  Lines            15226    15224       -2     
===============================================
+ Hits              8804     8808       +4     
+ Misses            4878     4874       -4     
+ Partials          1544     1542       -2     
Flag Coverage Δ
unit-tests 57.85% <3.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/config.go 34.64% <0.00%> (ø)
lib/utils/utils.go 24.35% <0.00%> (ø)
cmd/gossamer/config.go 73.10% <100.00%> (-0.14%) ⬇️
lib/blocktree/blocktree.go 54.83% <0.00%> (-1.30%) ⬇️
dot/rpc/websocket.go 37.62% <0.00%> (-1.00%) ⬇️
dot/network/service.go 58.78% <0.00%> (+0.67%) ⬆️
dot/core/service.go 52.97% <0.00%> (+1.08%) ⬆️
dot/network/sync.go 56.59% <0.00%> (+1.17%) ⬆️
dot/state/block_notify.go 85.18% <0.00%> (+1.85%) ⬆️
lib/blocktree/leaves.go 95.12% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34befe0...957d7b0. Read the comment docs.

Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only an inquisitory note

@@ -27,11 +27,11 @@ var (
// DefaultName Default node name
DefaultName = string("Kusama")
// DefaultID Default chain ID
DefaultID = string("ksmcc")
DefaultID = string("ksmcc3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the suffix of 3 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's what's in the genesis file

@noot noot merged commit 99a50eb into development Mar 16, 2021
@noot noot deleted the noot/rename-kusama branch March 16, 2021 22:16
github-actions bot pushed a commit that referenced this pull request Mar 16, 2021
noot: chore: rename ksmcc -> kusama (#1470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants